[coreboot] rm elfboot and ELF from v3 (not lar)

[Carl-Daniel Hailfinger]

On 16.02.2008 15:56, Stefan Reinauer wrote:
> * Myles Watson <mylesgw at gmail.com> [080215 22:33]:
>   
>> Here are my reasons:
>> 1. It wasn't being used anyway.
>>            Unless you used lar to load the elf in, the Makefile always
>> parsed the elf with -e
>>     
>
> Yes, using ELF was broken by this badly reviewed patch.
>
> This piece of code is just broken:
>
> # We now parse initram as ELF, so we need PARSEELF enabled
> # unconditionally.
> ifeq ($(CONFIG_PAYLOAD_PREPARSE_ELF), y)
>         PARSEELF = -e
> else
>         PARSEELF = -e
> endif
>
> This is kind of bad decay. It's unclean and hackish. 
>   

To really fix this, we have to separate payload parsing from
initram+stage2 parsing and use the PARSEELF parameter only for payload
parsing.

>> 2. It duplicated code.
>>            There is no reason for v3 to understand ELF when lar parses it.
>>     
>
> There are many reasons. See the list for reasons.
>
>
> Don't get me wrong. Feel free to fix the config option to disable ELF
> loading and feel free to use it in all your builds. 
>
> But don't just drop this stuff.
>
>   
>> Signed-off-by: Myles Watson <mylesgw at gmail.com>
>>     
>
> NACK.
>   

Myles, I think going with a config option for now is the best thing you
can do.

Regards,
Carl-Daniel

-- 
http://www.hailfinger.org/