[coreboot] Some work on the cn700 ram init

Peter Stuge peter at stuge.se
Fri Feb 22 13:08:14 CET 2008


On Fri, Feb 22, 2008 at 02:30:35AM -0500, Corey Osgood wrote:
> Squash a major bug in the previously committed cn700 patch (spd
> data only shifted 1 bit instead of 4), add Urbez Santana Roma's
> fixes for the ram setup data, and add the start of dynamic ram
> setup. This is an intermediate patch, there will be another to
> finish the dynamic ram setup, but the fix is very necessary. Note
> that this is not build tested.
> 
> Signed-off-by: Corey Osgood <corey.osgood at gmail.com>

I'd like to see Urbez' signoff in this commit too.


> +/* Table to transform the ram speed register value into a MHz value */ 
> +static int ram_speeds[6] = {100, 133, 166, 200, 266, 333};
> +/* Transform spd byte 40's tRFC value into a decimal */
> +static int byte_40_tRFC[6] = {0, 25, 33, 50, 66, 75 };

Could this be something like:

static int ram_speed_tRFC[][2] = {
	{100, 0}, {133, 25}, {166, 33}, {200, 50}, {266, 66}, {333, 75}
}

instead? Other than that:

Acked-by: Peter Stuge <peter at stuge.se>




More information about the coreboot mailing list