[LinuxBIOS] RESEND: patch: fix the problem with CONFIG_CONSOLE_VGA not pulling in the emulator

Torsten Duwe duwe at lst.de
Sat Jan 5 17:42:06 CET 2008


Here's the full story, which I'm hoping to address all related problems with.
We agreed that a VGA console and the need to run any option ROMs is mutually 
not strictly dependent, Luc's problem was that LBv2 code doesn't reflect 
that. There are 6 combinations:

* Console may be on VGA or not (e.g. serial)

_independently_

* LB might run
  - no option ROMs
  - only VGA option ROMs
  - all option ROMs

The combination "no option ROMs" / "VGA console" currently does not compile; 
Ron fixed that.

I would now additionally introduce CONFIG_VGA_ROM_RUN, to map all 6 
combinations. The implicit (broken) assumption that CONSOLE_VGA would also 
run the ROMs is lifted, and transferred to this new config option instead; 
the source code becomes less ambiguous.

This change is minimally intrusive, because all board configs that previously 
assumed CONSOLE_VGA would also run the ROMs didn't compile, they had to also 
specify PCI_ROM_RUN, so this new option only offers 2 new opportunities which 
didn't work before or were impossible to specify, respectively.

This part combines Luc's and Ron's patches, and adds the new option to 
clarify.

Signed-off-by: Torsten Duwe <duwe at lst.de>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: VGA_ROM_RUN-1
Type: text/x-diff
Size: 3042 bytes
Desc: not available
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20080105/32560eaa/attachment.bin>


More information about the coreboot mailing list