[LinuxBIOS] [PATCH] v3: add a check for a termination member

ron minnich rminnich at gmail.com
Sat Jan 5 23:29:36 CET 2008


On Jan 5, 2008 2:27 PM, Stefan Reinauer <stepan at coresystems.de> wrote:
>
> Many seconds, though just scanning for an 8 byte signature at a 16byte
> aligned address?

it's depressing, but yes. It's also surprising.

>
> That's a max of 32k string compares for every file that is _not_ found.
> Otherwise the number of compares is as high as the number of files in
> the lar minus 1. (ie. below 10)

no, it walks all of flash. see lib/lar.c -- or it seems to, it takes so long.

>
> We should fix linuxbios, so we do not look for files that are not there.
> rather than invent broken pseudo files.

works for me ... how?

ron




More information about the coreboot mailing list