[LinuxBIOS] Patch file for ld/fedora 8 issue as promised...

[Marc Karasek]

Attached is the latest.

It uses -ge instead of == or >.  This will take care of any time that 
there are more than 1 build-id in the ld -help output.

To address Myles concerns about the id.lds changes.  This was due to a 
bug I could not track down.  I left the original code in and comments 
were added as to the why for this change.  I could not find a better 
work around, or find the root cause for this problem.

I will try to debug this further and provide some output to the group. 


/*********************
Marc Karasek
MTS
Sun Microsystems
mailto:marc.karasek at sun.com
ph:770.360.6415
*********************/



Myles Watson wrote:
> On Jan 8, 2008 3:41 PM, Marc Karasek <Marc.Karasek at sun.com> wrote:
>   
>> So what is the general consensus ==1 or >0?
>>     
>
> I like the idea of using grep.  It seems much cleaner, and avoids that issue.
>
> The other sticking point for the patch the changes in
> src/arch/i386/lib/id.lds (See Ed's last message.)
>
> Myles
>
>   
>> Also,  I think I know how to commit back to the tree,  but do I need a
>> user account for this?
>>
>> /*********************
>> Marc Karasek
>> MTS
>> Sun Microsystems
>> mailto:marc.karasek at sun.com
>> ph:770.360.6415
>> *********************/
>>
>>
>>
>>
>> Myles Watson wrote:
>>     
>>> On Jan 7, 2008 8:15 AM, Marc Karasek <Marc.Karasek at sun.com> wrote:
>>>
>>>       
>>>> After looking at the script Myles sent, I immediately saw the problem.
>>>> I forgot that if  [ $build_id ] will always be true because it checks to
>>>> see if it is defined not the value of build_id.  My bad, sorry.
>>>>
>>>> I have made the changes and added an == 1 to the if statement.  Attached
>>>> is the new and I hope final patch file for this.
>>>>
>>>>
>>>>         
>>> It works for me (it doesn't add the load option.)
>>>
>>> Sorry to be picky, but it seems like this breaks if they mention
>>> build-id more than once in the help in the future.  I think >0 would
>>> be better than ==1.
>>>
>>> With that fixed, or if no one thinks that will ever happen:
>>> Acked-by: Myles Watson <myles at pel.cs.byu.edu>
>>>
>>>       
>>>> /*********************
>>>> Marc Karasek
>>>> MTS
>>>> Sun Microsystems
>>>> mailto:marc.karasek at sun.com
>>>> ph:770.360.6415
>>>> *********************/
>>>>
>>>>
>>>>
>>>> Ed Swierk wrote:
>>>>
>>>>
>>>>         
>>>>> On 1/4/08, Marc Karasek <Marc.Karasek at sun.com> wrote:
>>>>>
>>>>>
>>>>>           
>>>>>> I made a test script and ran it and it sets build_id = 1 properly.  I
>>>>>> have also included this script.
>>>>>>
>>>>>>
>>>>>>             
>>>>> The problem is that on Planet Bourne, zero means true and nonzero means false.
>>>>>
>>>>> --Ed
>>>>>
>>>>>
>>>>>           
-------------- next part --------------
A non-text attachment was scrubbed...
Name: flags_ld.patch
Type: text/x-patch
Size: 4168 bytes
Desc: not available
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20080109/eeae6679/attachment.patch>