[LinuxBIOS] Please add support for MX25L8005 and MX25L3205D

[Carl-Daniel Hailfinger]

On 10.01.2008 14:12, Harald Gutmann wrote:
> Am Donnerstag, 10. Januar 2008 13:56:05 schrieb Carl-Daniel Hailfinger:
>   
>> On 10.01.2008 13:39, Harald Gutmann wrote:
>>     
>>> Am Donnerstag, 10. Januar 2008 01:25:44 schrieb Carl-Daniel Hailfinger:
>>>       
>>>> Just adding the right values to flashchips.c is not enough. I need
>>>> "flashrom -V" output both with your patch and without your patch.
>>>>         
>>> first here is a diff between my "patched" and the actual plain svn
>>> version of flashrom:
>>>
>>> diff -ubr flashrom.plain/flashchips.c flashrom.patched/flashchips.c
>>> --- flashrom.plain/flashchips.c 2008-01-10 13:29:32.000000000 +0100
>>> +++ flashrom.patched/flashchips.c       2008-01-10 13:32:53.000000000
>>> +0100 @@ -52,6 +52,8 @@
>>>          probe_29f002,  erase_29f002,   write_29f002},
>>>         {"MX25L4005",   MX_ID,          MX_25L4005,     512, 256,
>>>          probe_spi,     generic_spi_chip_erase_c7,
>>> generic_spi_chip_write},
>>> +       {"MX25L8005",   MX_ID,          MX_25L8005,     1024, 256,
>>> +        probe_spi,     generic_spi_chip_erase_c7,
>>> generic_spi_chip_write},
>>>         {"SST25VF040B", SST_ID,         SST_25VF040B,   512,    256,
>>>         probe_spi,      generic_spi_chip_erase_c7,
>>> generic_spi_chip_write},
>>>         {"SST25VF016B", SST_ID,         SST_25VF016B,   2048,   256,
>>>       
>> That part of the patch is correct. Can you give me a Signed-off-by:
>> line? I will ack and commit. See
>> http://linuxbios.org/Development_Guidelines#Sign-off_Procedure for details.
>>     
>
> Signed-off-by: Harald Gutmann <harald.gutmann at gmx.net>
>   

Thanks, r3042.

>> Thanks, I now see that it is indeed a problem with the SPI translation.
>> Can you try to flash some random data to the rom? Verify will fail. Then
>> try to read back the rom and upload both original random data and
>> readback result somewhere (rapidshare etc.) and I'll try to find out
>> what the flash translation chip really supports.
>>     
> http://rapidshare.com/files/82696074/flashrom_files.tar.gz.html
>
> the file random_original.rom is the file i writed to the chip, where this file 
> was created using dd and /dev/urandom.
> the file random_read.rom is the file which i've read with flashrom after 
> writing the random_original.rom to the chip.
>   

OK, I now know the exact problem. The IT8716F flash translation function
does not work with chips bigger than 512 KByte unless you use a special
software enable routine.

>> And please tell me how much RAM the machine has (if it is more than 2
>> GB, I need the amount of Video RAM as well).
>>     
> My machine has 4Gb (4x1Gb) of RAM and Viedo RAM is 256Mb on an Nvidia Grapic 
> Card.
>   

Thanks, that is enough information.

Please update to current svn (it has your patch) and apply the patch
below. If random flashing with the patch works, can you give me an Ack?
If it doesn't work, can you upload the new random_read.com?

Forcibly enable LPC-to-SPI translation on IT8716F for the 0xFFEE0000 -
0xFFEFFFFF range.

Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net>

Index: flashrom-harald/spi.c
===================================================================
--- flashrom-harald/spi.c	(Revision 3042)
+++ flashrom-harald/spi.c	(Arbeitskopie)
@@ -137,6 +137,8 @@
 		printf("LPC write to serial flash %sabled\n",
 			(tmp & 1 << 4) ? "en" : "dis");
 		printf("serial flash pin %i\n",	(tmp & 1 << 5) ? 87 : 29);
+		tmp |= 1 << 2;
+		regwrite(port, 0x24, tmp);
 		/* LDN 0x7, reg 0x64/0x65 */
 		regwrite(port, 0x07, 0x7);
 		flashport = regval(port, 0x64) << 8;