[LinuxBIOS] [PATCH] v3: Print a message before resetting the processor

Carl-Daniel Hailfinger c-d.hailfinger.devel.2006 at gmx.net
Sat Jan 12 01:46:41 CET 2008


After configuring the PLL registers on Geode LX, we have to reset the
processor. However, nothing in the log tells the user why the processor
is being reset.
Example log follows:

LinuxBIOS-3.0.0 Fri Jan 11 15:53:52 MST 2008 starting...
Choosing fallback boot.
[...]
Fallback failed. Try normal boot
LAR: Attempting to open 'normal/initram/segment0'.
[...]
LAR: CHECK normal/initram/segment0 @ 0xfffc49b0
start 0xfffc4a00 len 5564 reallen 5564 compression 0 entry 0x000010ca loadaddress 0x00000000
Entry point is 0xfffc5aca
pll_reset: read msr 0x4c000014
_MSR GLCP_SYS_RSTPLL (4c000014) value is: 00000398:0000181e
Configuring PLL


LinuxBIOS-3.0.0 Fri Jan 11 15:53:52 MST 2008 starting...
Choosing fallback boot.
[...]


Print an informative message before resetting the processor.

Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net>

Index: LinuxBIOSv3-betterpllreset/arch/x86/geodelx/geodelx.c
===================================================================
--- LinuxBIOSv3-betterpllreset/arch/x86/geodelx/geodelx.c	(Revision 551)
+++ LinuxBIOSv3-betterpllreset/arch/x86/geodelx/geodelx.c	(Arbeitskopie)
@@ -187,6 +187,8 @@
 		/* Use SWFLAGS to remember: "we've already been here". */
 		msr_glcp_sys_pll.lo |= (1 << RSTPLL_LOWER_SWFLAGS_SHIFT);
 
+		printk(BIOS_INFO, "Resetting the processor after PLL "
+		       "configuration for the changes to take effect\n");
 		/* "Reset the chip" value */
 		msr_glcp_sys_pll.lo |= RSTPPL_LOWER_CHIP_RESET_SET;
 		wrmsr(GLCP_SYS_RSTPLL, msr_glcp_sys_pll);






More information about the coreboot mailing list