[coreboot] r3053 - in trunk/coreboot-v2: . documentation documentation/RFC src/arch/i386 src/arch/i386/boot src/arch/i386/include/arch src/arch/i386/init src/arch/i386/lib src/arch/ppc src/arch/ppc/boot src/arch/ppc/init src/boot src/config src/console src/cpu/amd/car src/cpu/amd/model_gx2 src/cpu/amd/model_lx src/cpu/amd/sc520 src/cpu/emulation/qemu-i386 src/cpu/ppc/mpc74xx src/cpu/ppc/ppc4xx src/cpu/ppc/ppc7xx src/cpu/x86/32bit src/cpu/x86/car src/cpu/x86/lapic src/cpu/x86/pae src/devices/emulator/x86emu src/drivers/ati/ragexl src/drivers/pci/onboard src/include src/include/boot src/include/console src/include/device src/include/x86emu src/lib src/mainboard/a-trend/atc-6220 src/mainboard/advantech/pcm-5820 src/mainboard/agami/aruma src/mainboard/amd/db800 src/mainboard/amd/norwich src/mainboard/amd/rumba src/mainboard/amd/serengeti_cheetah src/mainboard/amd/serengeti_cheetah_fam10 src/mainboard/arima/hdama src/mainboard/artecgroup/dbe61 src/mainboard/artecgroup/dbe61/realmode src/mainboard/asi/mb_5blmp src/mainboard/asus/a8n_e src/mainboard/asus/a8v-e_se src/mainboard/asus/mew-am src/mainboard/asus/mew-vm src/mainboard/asus/p2b src/mainboard/asus/p2b-f src/mainboard/asus/p3b-f src/mainboard/axus/tc320 src/mainboard/azza/pt-6ibd src/mainboard/bcom/winnet100 src/mainboard/biostar/m6tba src/mainboard/broadcom/blast src/mainboard/compaq/deskpro_en_sff_p600 src/mainboard/dell/s1850 src/mainboard/digitallogic/adl855pc src/mainboard/digitallogic/msm586seg src/mainboard/digitallogic/msm800sev src/mainboard/eaglelion/5bcm src/mainboard/embeddedplanet/ep405pc src/mainboard/emulation/qemu-i386 src/mainboard/gigabyte/ga-6bxc src/mainboard/gigabyte/ga_2761gxdk src/mainboard/gigabyte/m57sli src/mainboard/ibm/e325 src/mainboard/ibm/e326 src/mainboard/iei/juki-511p src/mainboard/iei/nova4899r src/mainboard/intel/jarrell src/mainboard/intel/xe7501devkit src/mainboard/iwill/dk8_htx src/mainboard/iwill/dk8s2 src/mainboard/iwill/dk8x src/mainboard/lippert/frontrunner src/mainboard/motorola/sandpoint src/mainboard/motorola/sandpointx3_altimus_mpc7410 src/mainboard/msi/ms6178 src/mainboard/msi/ms7260 src/mainboard/msi/ms9185 src/mainboard/msi/ms9282 src/mainboard/newisys/khepri src/mainboard/nvidia/l1_2pvv src/mainboard/olpc/btest src/mainboard/olpc/rev_a src/mainboard/pcengines/alix1c src/mainboard/sunw/ultra40 src/mainboard/supermicro/h8dmr src/mainboard/supermicro/x6dai_g src/mainboard/supermicro/x6dhe_g src/mainboard/supermicro/x6dhe_g2 src/mainboard/supermicro/x6dhr_ig src/mainboard/supermicro/x6dhr_ig2 src/mainboard/technologic/ts5300 src/mainboard/totalimpact/briq src/mainboard/tyan/s1846 src/mainboard/tyan/s2735 src/mainboard/tyan/s2850 src/mainboard/tyan/s2875 src/mainboard/tyan/s2880 src/mainboard/tyan/s2881 src/mainboard/tyan/s2882 src/mainboard/tyan/s2885 src/mainboard/tyan/s2891 src/mainboard/tyan/s2892 src/mainboard/tyan/s2895 src/mainboard/tyan/s2912 src/mainboard/tyan/s4880 src/mainboard/tyan/s4882 src/mainboard/via/epia src/mainboard/via/epia-m src/northbridge/amd/amdfam10 src/northbridge/amd/amdht src/northbridge/amd/amdk8 src/northbridge/amd/amdmct/mct src/northbridge/amd/gx2 src/northbridge/intel/i855pm src/northbridge/motorola/mpc107 src/northbridge/via/vt8601 src/northbridge/via/vt8623 src/southbridge/amd/cs5530 src/southbridge/amd/cs5536 src/southbridge/broadcom/bcm5785 src/southbridge/intel/i82801ca src/southbridge/ricoh/rl5c476 src/stream src/superio/smsc/lpc47n217 targets targets/a-trend/atc-6220 targets/advantech/pcm-5820 targets/agami/aruma targets/amd/db800 targets/amd/norwich targets/amd/rumba targets/amd/serengeti_cheetah targets/amd/serengeti_cheetah_fam10 targets/arima/hdama targets/artecgroup/dbe61 targets/asi/mb_5blmp targets/asus/a8n_e targets/asus/a8v-e_se targets/asus/mew-am targets/asus/mew-vm targets/asus/p2b targets/asus/p2b-f targets/asus/p3b-f targets/axus/tc320 targets/azza/pt-6ibd targets/bcom/winnet100 targets/biostar/m6tba targets/broadcom/blast targets/compaq/deskpro_en_sff_p600 targets/dell/s1850 targets/digitallogic/adl855pc targets/digitallogic/msm586seg targets/digitallogic/msm800sev targets/eaglelion/5bcm targets/embeddedplanet/ep405pc targets/emulation/qemu-i386 targets/gigabyte/ga-6bxc targets/gigabyte/ga_2761gxdk targets/gigabyte/m57sli targets/ibm/e325 targets/ibm/e326 targets/iei/juki-511p targets/iei/nova4899r targets/intel/xe7501devkit targets/iwill/dk8_htx targets/iwill/dk8s2 targets/iwill/dk8x targets/lippert/frontrunner targets/momentum/apache targets/motorola/sandpoint targets/msi/ms6178 targets/msi/ms7260 targets/msi/ms9185 targets/msi/ms9282 targets/newisys/khepri targets/nvidia/l1_2pvv targets/olpc/btest targets/olpc/rev_a targets/pcengines/alix1c targets/sunw/ultra40 targets/supermicro/h8dmr targets/technologic/ts5300 targets/totalimpact/briq targets/tyan/s1846 targets/tyan/s2735 targets/tyan/s2850 targets/tyan/s2875 targets/tyan/s2880 targets/tyan/s2881 targets/tyan/s2882 targets/tyan/s2885 targets/tyan/s2891 targets/tyan/s2892 targets/tyan/s2895 targets/tyan/s2912 targets/tyan/s4880 targets/tyan/s4882 targets/via/epia targets/via/epia-m util/ADLO util/ADLO/bochs/bios uti

Peter Stuge peter at stuge.se
Fri Jan 18 17:14:49 CET 2008


On Fri, Jan 18, 2008 at 04:08:58PM +0100, svn at coreboot.org wrote:
> -    See http://snapshots.linuxbios.org/
> +    See http://tracker.coreboot.org/

snapshots in the tracker?


> -unsigned long write_linuxbios_table( 
> +unsigned long write_coreboot_table( 

Really?


> -		/* Create cmos checksum entry in linuxbios table */
> +		/* Create cmos checksum entry in coreboot table */
>  		lb_cmos_checksum(head);

Inconsistent since the function name doesn't change.


>  struct lb_memory *get_lb_mem(void);

Likewise..


> -// Ported from Etherboot to LinuxBIOS 2005-08 by Steve Magnani
> +// Ported from Etherboot to coreboot 2005-08 by Steve Magnani

It wasn't called coreboot back then.


> -		{ LB_TAG_ASSEMBLER,      linuxbios_assembler,      },
> +		{ LB_TAG_ASSEMBLER,      coreboot_assembler,      },

LB_ ..


And probably many more. I stopped here.

I am with Carl-Daniel. I think we should consider reverting some
hunks of this patch.


//Peter




More information about the coreboot mailing list