[coreboot] patch: first steps to VSA support in v3
rminnich at gmail.com
Thu Jan 24 20:05:52 CET 2008
On Jan 24, 2008 10:06 AM, Carl-Daniel Hailfinger
<c-d.hailfinger.devel.2006 at gmx.net> wrote:
> > --- northbridge/amd/geodelx/vsmsetup.c (revision 0)
> > +++ northbridge/amd/geodelx/vsmsetup.c (revision 0)
> > @@ -0,0 +1,302 @@
> > +/*
> > + * Erik Arjan Hendriks <hendriks at lanl.gov>
> Missing "copyright"?
I will fix this.
> > + * Copyright (C) 2000 Scyld.
> > + * Copyright (C) 2000 Scyld Computing Corporation
> > + * Copyright (C) 2001 University of California. LA-CC Number 01-67.
> Is LA-CC "Los Alamos Computer Code"?
It actually depends on who you ask, but we have to leave that in there :-)
> > + buf = (unsigned char *)VSA2_BUFFER;
> > + // FIXME
> > + //olen = unrv2b((u8 *) rom, buf, &ilen);
> How exactly is the VSA going to end up in VSA2_BUFFER if you don't
> copy/uncompress it there?
This code won't run yet. I am doing this initial commit as I don't
want to have another hard drive failure and lose it ... there is more
work to be done.
This code moves the lx state from 'not working' to 'not working', so I
don't mind it too much.
> Rest looks good so far from a first glance.
Good to hear. I would like to commit this because I am paranoid about
losing bits ... but I can try to fix that uncompress thing above.
More information about the coreboot