[coreboot] PATCH: Add Spansion S25FL016A to flashrom

[Carl-Daniel Hailfinger]

On 25.01.2008 02:11, Peter Stuge wrote:
> On Thu, Jan 24, 2008 at 04:57:35PM +0100, Carl-Daniel Hailfinger wrote:
>   
>>> Then I wrote rand.bin which is 2MB of /dev/random. This
>>> consistently reads back as something quite different
>>>       
>> This looks like the chip was not erased between writing
>> 4*coreboot.rom and the random image.
>>     
>
> You mean I have to erase? I forgot.
>   

Yes-

> I'm thinking maybe -w should erase by default and that
> another option (-W?) writes without erase. Thoughts?
> I can save this idea for the ultimate larflash tool though.
>   

Flashrom could read in the chip, then issue a warning if it isn't empty.
This increases time needed for flashing, though.

>> Can you verify the chip is indeed blank after erase, and then flash
>> the random image again?
>>     
>
> Yep, that works.
>   

Good.

>>> +	 probe_spi,	generic_spi_chip_erase_c7,	over512k_spi_chip_write, over512k_spi_chip_read},
>>>       
>> You can use generic_spi_* instead of over512k_spi_*.
>>     
>
> Thanks, I was running with generic_, then I changed the code but
> never rebuilt, read up on the thread and then forgot I had changed
> the code before the svn diff.
>
> Revised patch attached. Not the best performance, but it works.
>
> m57sli tmp # time flashrom -m gigabyte:m57sli -w 2m.bin   
> Calibrating delay loop... OK.
> No coreboot table found.
> Found chipset "NVIDIA MCP55", enabling flash write... OK.
> Found board "GIGABYTE GA-M57SLI-S4": enabling flash write... Serial
> flash segment 0xfffe0000-0xffffffff enabled
> Serial flash segment 0x000e0000-0x000fffff enabled
> Serial flash segment 0xffee0000-0xffefffff disabled
> Serial flash segment 0xfff80000-0xfffeffff enabled
> LPC write to serial flash enabled
> serial flash pin 29
> OK.
> S25FL016A found at physical address 0xffe00000.
> Flash part is S25FL016A (2048 KB).
>
> real    10m10.446s
> user    10m10.260s
> sys     0m0.180s
> m57sli tmp # 
>
>
> //Peter
>   

> Add ids and chip entry for Spansion S25FL016A to flashrom, tested, working.
>
> Signed-off-by: Peter Stuge <peter at stuge.se>
>   

Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net>

Thanks, committed in r3074.

Regards,
Carl-Daniel