[coreboot] [PATCH] v3: Fix ADL MSM800SEV build
Carl-Daniel Hailfinger
c-d.hailfinger.devel.2006 at gmx.net
Fri Jul 11 23:15:08 CEST 2008
On 11.07.2008 21:51, ron minnich wrote:
> On Fri, Jul 11, 2008 at 12:46 PM, Uwe Hermann <uwe at hermann-uwe.de> wrote:
>
>> On Fri, Jul 11, 2008 at 06:50:27PM +0200, Carl-Daniel Hailfinger wrote:
>>
>>>> + pci at 15,2 {
>>>> + /config/("southbridge/amd/cs5536/ide");
>>>> + enable_ide = "1";
>>>>
>>>>
>>> What about removing the line above? In theory, stuff should still compile.
>>>
>> Yep, compiles, no idea if it actually works (or how) on the board.
>>
>> New patch attached.
>>
>
> taking that out seems a mistake. Until we can test, leave too much
> stuff in, don't take too much stuff out.
>
Yes, the MSM800SEV has IDE, so my line removal request was mistaken.
Your original patch is
Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net>
Regards,
Carl-Daniel
--
http://www.hailfinger.org/
More information about the coreboot
mailing list