[coreboot] msrtool

[Tom Sylla]

The decode might seem interesting, but this is close to veering down a 
bad path.

You do *not* want to try and futz around with any of those settings. The 
values in the table (plus the missing one for unterminated) are the only 
ones you will ever want to use. Thousands of hours of debug and 
validation time by AMD came up with those numbers. You should not have 
to "tweak" any of those settings to get something to work. There are 
comments in the coreboot source to that effect, too.

My only reason to point this out is that by decoding it, you are sort of 
implying that the fields might need to be tweaked.


Peter Stuge wrote:
> On Sat, Jul 12, 2008 at 09:02:36AM -0700, ron minnich wrote:
>> Thanks for the decode!
> 
> Today's lesson: Don't trust my decodes right now.
> 
> 
>> suggestion for all of us. Every time we decode this stuff, we
>> *write a program* -- perl, C, who cares -- that does it for us.
> 
> Yeah. I did that. The diff output from your coreboot value vs. the
> reference value is attached. As you can see I shifted some bits wrong
> when doing the decode manually. I need some practice I guess.
> 
> 
>> And, coreboot will have another cool property -- a huge suite of
>> programs for figuring these settings out.
> 
> Yes, definately. I still want to fix up msrtool a little more but
> will send very soon.
> 
> 
> //Peter
>