[coreboot] v3 patch: fix dtc to correctly parse @x values as hex, not decimal.

Carl-Daniel Hailfinger c-d.hailfinger.devel.2006 at gmx.net
Tue Jul 29 18:53:31 CEST 2008


On 29.07.2008 18:21, ron minnich wrote:
> attached.
>
> ron
>   
> I misunderstood the dts when I wrote this code. 
> The @ values are implicitly hex. Correctly emit hex constants for all cases, 
> including the pci a,b syntax. 
>
> Tested on dbe62. Note that before this patch goes in we need to change ALL 
> dts files to be hex. 
>
> Also a small buglet:  fix the strcmp on ioport to match 6, not 3, chars. 
>
> Signed-off-by: Ronald G. Minnich <rminnich at gmail.com>

AFAICS this will break all targets unless each dts is fixed as well. If
you include the fixed dts for each board, the patch is
Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net>

./mainboard/adl/msm800sev/dts
./mainboard/amd/db800/dts
./mainboard/amd/norwich/dts
./mainboard/artecgroup/dbe61/dts
./mainboard/artecgroup/dbe62/dts
./mainboard/emulation/qemu-x86/dts
./mainboard/pcengines/alix1c/dts
./mainboard/pcengines/alix2c3/dts

Regards,
Carl-Daniel

-- 
http://www.hailfinger.org/





More information about the coreboot mailing list