[coreboot] ram init help on the i82830

[Joseph Smith]

On Mon, 02 Jun 2008 23:41:11 -0400, Joseph Smith <joe at settoplinux.org>
wrote:
> 
>>
>>>        /* See if there are 2 sticks. */
>>>        if((drb1 != 0) && (drb3 != 0)) {
>>
>> Should be:
>>
>> if((drb1 != 0) && (drb3 != drb1))
>>
> In theory this would not work. If you have a so-dimm in slot0 drb3 would
> ==
> drb1. The register would look something like this:
> 
> 04 04 04 04
> 
> for a 128MB single sidded so-dimm in the first slot.
> 
Actually, this should work:

if((drb1 != 0) && (drb3 > drb1)) {

This way if drb1 is not zero, you know you have a so-dimm in slot0.
And if drb3 is greater than drb1, you know you have a so-dimm in slot1.

-- 
Thanks,
Joseph Smith
Set-Top-Linux
www.settoplinux.org