[coreboot] [PATCH][v3] Argument order in compiler options
Peter Stuge
peter at stuge.se
Fri Jun 6 22:13:49 CEST 2008
On Tue, Jun 03, 2008 at 04:30:42PM +0200, Patrick Georgi wrote:
> Signed-Off-By: Patrick Georgi <patrick at georgi-clan.de>
With the below question answered, this is:
Acked-by: Peter Stuge <peter at stuge.se>
> Index: util/kconfig/lxdialog/Makefile
> ===================================================================
> --- util/kconfig/lxdialog/Makefile (revision 687)
> +++ util/kconfig/lxdialog/Makefile (working copy)
> @@ -24,8 +24,8 @@
>
> $(obj)/util/kconfig/lxdialog/lxdialog: $(obj)/dochecklxdialog $(patsubst %,$(obj)/util/kconfig/lxdialog/%,$(lxdialog-objs))
> $(Q)printf " HOSTCC $(subst $(shell pwd)/,,$(@))\n"
> - $(Q)$(HOSTCC) $(HOST_LOADLIBES) \
> - $(patsubst %,$(obj)/util/kconfig/lxdialog/%,$(lxdialog-objs)) -o $@
> + $(Q)$(HOSTCC) \
> + $(patsubst %,$(obj)/util/kconfig/lxdialog/%,$(lxdialog-objs)) -o $@ $(HOST_LOADLIBES)
HOST_LOADLIB*E*S
Is that last E a typo?
>
> $(obj)/util/kconfig/lxdialog/%.o: $(src)/util/kconfig/lxdialog/%.c
> $(Q)mkdir -p $(obj)/util/kconfig/lxdialog/
> Index: util/kconfig/Makefile
> ===================================================================
> --- util/kconfig/Makefile (revision 687)
> +++ util/kconfig/Makefile (working copy)
> @@ -102,11 +102,11 @@
>
> $(obj)/util/kconfig/mconf: $(patsubst %,$(obj)/util/kconfig/%,$(mconf-objects))
> $(Q)printf " HOSTCC $(subst $(shell pwd)/,,$(@))\n"
> - $(Q)$(HOSTCC) $(CURSESLIBS) $(INTLLIBS) -o $@ $^
> + $(Q)$(HOSTCC) -o $@ $^ $(CURSESLIBS) $(INTLLIBS)
>
> $(obj)/util/kconfig/conf: $(patsubst %,$(obj)/util/kconfig/%,$(conf-objects))
> $(Q)printf " HOSTCC $(subst $(shell pwd)/,,$(@))\n"
> - $(Q)$(HOSTCC) $(CURSESLIBS) -o $@ $^
> + $(Q)$(HOSTCC) -o $@ $^ $(CURSESLIBS)
>
> $(obj)/util/kconfig/qconf: $(patsubst %,$(obj)/util/kconfig/%,$(qconf-objects))
> $(Q)printf " HOSTCXX $(subst $(shell pwd)/,,$(@))\n"
More information about the coreboot
mailing list