[coreboot] flashrom: Cache probed id:s

Peter Stuge peter at stuge.se
Tue Jun 24 04:17:47 CEST 2008


Please see attached fr.cacheprobe_goto.patch.

For those who fiercly advocate against goto; please compare
fr.cacheprobe_goto.patch (which I propose to commit) with the mess in
fr.cacheprobe_if.patch (which is not signed off and only included for
reference) - goto ftw!

Timing:

flashrom r3386: 1.099s
flashrom r3387 (10ms patch): 1.880s
flashrom r3387 + this patch: 0.882s

May be considered petty to optimize away this one second, but it is
quite noticeable, and not neccessary.


//Peter
-------------- next part --------------
A non-text attachment was scrubbed...
Name: fr.cacheprobe_goto.patch
Type: text/x-diff
Size: 12058 bytes
Desc: not available
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20080624/878efb9f/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: fr.cacheprobe_if.patch
Type: text/x-diff
Size: 23279 bytes
Desc: not available
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20080624/878efb9f/attachment-0001.bin>


More information about the coreboot mailing list