[coreboot] r3391 - in trunk/coreboot-v2: src/mainboard/a-trend src/mainboard/a-trend/atc-6240 targets/a-trend targets/a-trend/atc-6240

[Uwe Hermann]

Hi,

On Thu, Jun 26, 2008 at 10:24:17PM +0200, Stefan Reinauer wrote:
> please also add a Config-abuild.lb for this mainboard. Without, the  
> resulting image will have no mainboard name set.

You mean the MAINBOARD_VENDOR / MAINBOARD_PART_NUMBER variables?


> (BTW, why don't you set the mainboard name in the mainboard's options.lb  
> to begin with?)

Just a minor quirk, I like the Options.lb to be as generic as possible
and stuff the board-specific options into targets/.../Config.lb as
overrides. You'll notice that all the 1-2 dozen 440BX boards have an
identical or almost-identical Options.lb, the specific variables all
being in targets/.../Config.lb.

Earlier I was planning to unify the Options.lb for them one day, adding one
copy $somewhere, and using a symlink for the other ones, but that's probably
not going to happen anymore, and I don't care enough about it anymore
either, I guess.

Would moving MAINBOARD_VENDOR / MAINBOARD_PART_NUMBER to Options.lb fix
the problem with abuild?


Uwe.
-- 
http://www.hermann-uwe.de  | http://www.holsham-traders.de
http://www.crazy-hacks.org | http://www.unmaintained-free-software.org