[coreboot] [PATCH] [flashrom] initial numonyx support

[Carl-Daniel Hailfinger]

On 27.06.2008 18:53, Stefan Reinauer wrote:
> Carl-Daniel Hailfinger wrote:
>   
>> On 27.06.2008 17:44, Stefan Reinauer wrote:
>>   
>>     
>>> see patch
>>>
>>> * drop erroneous "unknown flash chip" entries. They badly clash with the
>>>   "multiple flash chip support" and are no longer required since it's possible
>>>   to force a flash chip with Peter's last patch.
>>>   
>>>     
>>>       
>> NACK that part. The functionality provided by the "unknown xy flash
>> chip" entries is still not available otherwise. Removing code just
>> because it does not work perfectly as expected is something you opposed
>> a few days ago.
>>   
>>     
>
> And I was convinced that it is ok in case it never worked correctly.
>   

It did work correctly, but the "multiple flash chip support" patch made
it a lot less useful.

> So what do you suggest is the right fix?  Dummy entries is not it.
>   

Reverting multiple flash chip support would be one of the possible
solutions. The preferred way to fix this would be a per-bus probe list,
decoding the vendor ID if the device ID is unknown. By the way, that
would also be the only correct solution for multiple flash chip recognition.

Regards,
Carl-Daniel

-- 
http://www.hailfinger.org/