[coreboot] r3393 - trunk/util/flashrom

[Carl-Daniel Hailfinger]

On 29.06.2008 01:46, Stefan Reinauer wrote:
> Carl-Daniel Hailfinger wrote:
>>> The sparse debug printfs create a wrong impression here.
>>>     
>>
>> Then we should definitely apply my patch to make sure nobody gets a
>> wrong impression in the future.
> Absolutely; and a couple more like that.

Good. Care to ack my patch?

> We might also want to consider several log levels?
>
> -v verbose
> -vv verbose and debug drivers
> -vvv verbose, debug drivers and dump registers at every chance to do so

That's a pretty good idea. Perhaps we want to refine that proposal a bit
more with debug bitmasks. Then again, that might be overkill.

More ICH SPI debug messages are definitely needed before 1.0. Log levels
are post-1.0 material IMHO.

Regards,
Carl-Daniel

-- 
http://www.hailfinger.org/