[coreboot] first output: dbe62 and v3

[Carl-Daniel Hailfinger]

On 05.03.2008 18:13, Marc Jones wrote:
> ron minnich wrote:
>   
>> One thing I plan to change pretty soon: power button control can move
>> from stage1 to stage2, and power button control will be managed in dts
>> (another dts setting we would NOT want visible in Kconfig; you could
>> render a board totally unbootable and unrepairable with the wrong
>> setting. Kconfig should be for settings that are safe to change).
>>     
>
> This would be great. It should be easy to add a dts item and call 
> cs5536_setup_power_button or not. Moving it to stage 2 should be fine 
> BUT until the power button is setup it won't work. Some people might not 
> like that if you hang or delay somewhere prior to it being setup.
>   

Can we set up the power button in a way that makes it work always, then 
change the setup in stage2?


>>         msr = rdmsr(GLCP_SYS_RSTPLL);
>>         if (msr.lo & (0x3f << 26)) {
>>                 /* PLL is already set and we are reboot from PLL reset. */
>>                 return;
>>         }
>>
>>         cs5536_setup_idsel();
>>     
> Need this to do stage2. Without it the 5536 won't decode PCI.
>   

Did you mean stage1?

Regards,
Carl-Daniel

-- 
http://www.hailfinger.org/