[coreboot] [PATCH 3/5] Intel 3100, version 3

[Ed Swierk]

On Thu, Mar 13, 2008 at 3:38 PM, Peter Stuge <peter at stuge.se> wrote:
>  Also ack, but..
>
>  > +static void smbus_write_byte(unsigned device, unsigned address, unsigned char val)
>  > +{
>  > +     if (smbus_wait_until_ready(SMBUS_IO_BASE) < 0) {
>  > +             return;
>  > +     }
>  > +     return;
>  > +}
>
>  ..is this really working? Could be just the function call in that
>  case.

Neither smbus_write_byte() nor smbus_write_block() is ever called, it
turns out. So they probably don't work :-)

Here is an updated patch with those functions removed.

Signed-off-by: Ed Swierk <eswierk at arastra.com>

--Ed
-------------- next part --------------
A non-text attachment was scrubbed...
Name: intel3100-southbridge.patch
Type: text/x-patch
Size: 33683 bytes
Desc: not available
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20080313/90a1bc74/attachment.patch>