[coreboot] [PATCH] flashrom: Prepare for ICH7/ICH8 SPI support

[Ward Vandewege]

On Fri, Mar 14, 2008 at 02:52:25PM +0100, Carl-Daniel Hailfinger wrote:
> Testers wanted for all ICH versions!
> 
> 
> Prepare for ICH7/ICH8 SPI support by adding some debugging for all
> ICH* chipsets. Functionality (except printing) should be unchanged.

My laptop (Dell 1420N) has ICH8:

# lspci -nn
00:00.0 Host bridge [0600]: Intel Corporation Mobile PM965/GM965/GL960 Memory
Controller Hub [8086:2a00] (rev 0c)
00:02.0 VGA compatible controller [0300]: Intel Corporation Mobile
GM965/GL960 Integrated Graphics Controller [8086:2a02] (rev 0c)
00:02.1 Display controller [0380]: Intel Corporation Mobile GM965/GL960
Integrated Graphics Controller [8086:2a03] (rev 0c)
00:1a.0 USB Controller [0c03]: Intel Corporation 82801H (ICH8 Family) USB
UHCI Contoller #4 [8086:2834] (rev 02)
00:1a.1 USB Controller [0c03]: Intel Corporation 82801H (ICH8 Family) USB
UHCI Controller #5 [8086:2835] (rev 02)
00:1a.7 USB Controller [0c03]: Intel Corporation 82801H (ICH8 Family) USB2
EHCI Controller #2 [8086:283a] (rev 02)
00:1b.0 Audio device [0403]: Intel Corporation 82801H (ICH8 Family) HD Audio
Controller [8086:284b] (rev 02)
00:1c.0 PCI bridge [0604]: Intel Corporation 82801H (ICH8 Family) PCI Express
Port 1 [8086:283f] (rev 02)
00:1c.1 PCI bridge [0604]: Intel Corporation 82801H (ICH8 Family) PCI Express
Port 2 [8086:2841] (rev 02)
00:1c.3 PCI bridge [0604]: Intel Corporation 82801H (ICH8 Family) PCI Express
Port 4 [8086:2845] (rev 02)
00:1c.5 PCI bridge [0604]: Intel Corporation 82801H (ICH8 Family) PCI Express
Port 6 [8086:2849] (rev 02)
00:1d.0 USB Controller [0c03]: Intel Corporation 82801H (ICH8 Family) USB
UHCI Controller #1 [8086:2830] (rev 02)
00:1d.1 USB Controller [0c03]: Intel Corporation 82801H (ICH8 Family) USB
UHCI Controller #2 [8086:2831] (rev 02)
00:1d.2 USB Controller [0c03]: Intel Corporation 82801H (ICH8 Family) USB
UHCI Controller #3 [8086:2832] (rev 02)
00:1d.7 USB Controller [0c03]: Intel Corporation 82801H (ICH8 Family) USB2
EHCI Controller #1 [8086:2836] (rev 02)
00:1e.0 PCI bridge [0604]: Intel Corporation 82801 Mobile PCI Bridge
[8086:2448] (rev f2)
00:1f.0 ISA bridge [0601]: Intel Corporation 82801HEM (ICH8M) LPC Interface
Controller [8086:2815] (rev 02)
00:1f.1 IDE interface [0101]: Intel Corporation 82801HBM/HEM (ICH8M/ICH8M-E)
IDE Controller [8086:2850] (rev 02)
00:1f.2 SATA controller [0106]: Intel Corporation 82801HBM/HEM
(ICH8M/ICH8M-E) SATA AHCI Controller [8086:2829] (rev 02)
00:1f.3 SMBus [0c05]: Intel Corporation 82801H (ICH8 Family) SMBus Controller
[8086:283e] (rev 02)
03:01.0 FireWire (IEEE 1394) [0c00]: Ricoh Co Ltd R5C832 IEEE 1394 Controller
[1180:0832] (rev 05)
03:01.1 Generic system peripheral [0805]: Ricoh Co Ltd R5C822
SD/SDIO/MMC/MS/MSPro Host Adapter [1180:0822] (rev 22)
03:01.2 System peripheral [0880]: Ricoh Co Ltd R5C843 MMC Host Controller
[1180:0843] (rev 12)
03:01.3 System peripheral [0880]: Ricoh Co Ltd R5C592 Memory Stick Bus Host
Adapter [1180:0592] (rev 12)
03:01.4 System peripheral [0880]: Ricoh Co Ltd xD-Picture Card Controller
[1180:0852] (rev 12)
09:00.0 Ethernet controller [0200]: Broadcom Corporation NetLink BCM5906M
Fast Ethernet PCI Express [14e4:1713] (rev 02)
0c:00.0 Network controller [0280]: Intel Corporation PRO/Wireless 3945ABG
Network Connection [8086:4222] (rev 02)

Your patch does not seem to do much though:

# ./flashrom -V
Calibrating delay loop... 338M loops per second. OK.
No coreboot table found.
WARNING: No chipset found. Flash detection will most likely fail.
Probing for Am29F040B, 512 KB
probe_29f040b: id1 0x60, id2 0x8a
Probing for Am29LV040B, 512 KB
probe_29f040b: id1 0x60, id2 0x8a
Probing for Am29F016D, 2048 KB
probe_29f040b: id1 0xff, id2 0xff
Probing for AE49F2008, 256 KB
probe_jedec: id1 0x30, id2 0xc
Probing for At29C040A, 512 KB
probe_jedec: id1 0x60, id2 0x8a
Probing for At29C020, 256 KB
probe_jedec: id1 0x30, id2 0xc
Probing for At49F002(N), 256 KB
probe_jedec: id1 0x30, id2 0xc
Probing for At49F002(N)T, 256 KB
probe_jedec: id1 0x30, id2 0xc
Probing for EN29F002(A)(N)T, 256 KB
probe_jedec: id1 0x30, id2 0xc
Probing for EN29F002(A)(N)B, 256 KB
probe_jedec: id1 0x30, id2 0xc
Probing for MBM29F400TC, 512 KB
probe_m29f400bt: id1 0x60, id2 0xb
Probing for MX29F002, 256 KB
probe_29f002: id1 0x30, id2 0xc
Probing for MX25L4005, 512 KB
generic_spi_command called, but no SPI chipset detected
Probing for MX25L8005, 1024 KB
generic_spi_command called, but no SPI chipset detected
Probing for MX25L3205, 4096 KB
generic_spi_command called, but no SPI chipset detected
Probing for S25FL016A, 2048 KB
generic_spi_command called, but no SPI chipset detected
Probing for SST25VF040B, 512 KB
generic_spi_command called, but no SPI chipset detected
Probing for SST25VF016B, 2048 KB
generic_spi_command called, but no SPI chipset detected
Probing for SST29EE020A, 256 KB
probe_jedec: id1 0x30, id2 0xc
Probing for SST28SF040A, 512 KB
probe_28sf040: id1 0x60, id2 0x8a
Probing for SST39SF010A, 128 KB
probe_jedec: id1 0xff, id2 0xff
Probing for SST39SF020A, 256 KB
probe_jedec: id1 0x30, id2 0xc
Probing for SST39SF040, 512 KB
probe_jedec: id1 0x60, id2 0x8a
Probing for SST39VF020, 256 KB
probe_jedec: id1 0x30, id2 0xc
Probing for SST49LF040B, 512 KB
probe_jedec: id1 0x60, id2 0x8a
Probing for SST49LF040, 512 KB
probe_jedec: id1 0x60, id2 0x8a
Probing for SST49LF020A, 256 KB
probe_jedec: id1 0x30, id2 0xc
Probing for SST49LF080A, 1024 KB
probe_jedec: id1 0xff, id2 0xff
Probing for SST49LF002A/B, 256 KB
probe_jedec: id1 0x30, id2 0xc
Probing for SST49LF003A/B, 384 KB
probe_jedec: id1 0x3, id2 0x5
Probing for SST49LF004A/B, 512 KB
probe_jedec: id1 0x60, id2 0x8a
Probing for SST49LF008A, 1024 KB
probe_jedec: id1 0xff, id2 0xff
Probing for SST49LF004C, 512 KB
probe_49lfxxxc: id1 0x60, id2 0x8a
Probing for SST49LF008C, 1024 KB
probe_49lfxxxc: id1 0xff, id2 0xff
Probing for SST49LF016C, 2048 KB
probe_49lfxxxc: id1 0xff, id2 0xff
Probing for SST49LF160C, 2048 KB
probe_49lfxxxc: id1 0xff, id2 0xff
Probing for Pm49FL002, 256 KB
probe_jedec: id1 0x30, id2 0xc
Probing for Pm49FL004, 512 KB
probe_jedec: id1 0x60, id2 0x8a
Probing for Pm25LV512, 64 KB
generic_spi_command called, but no SPI chipset detected
Probing for Pm25LV010, 128 KB
generic_spi_command called, but no SPI chipset detected
Probing for Pm25LV020, 256 KB
generic_spi_command called, but no SPI chipset detected
Probing for Pm25LV040, 512 KB
generic_spi_command called, but no SPI chipset detected
Probing for Pm25LV080B, 1024 KB
generic_spi_command called, but no SPI chipset detected
Probing for Pm25LV016B, 2048 KB
generic_spi_command called, but no SPI chipset detected
Probing for W29C011, 128 KB
probe_jedec: id1 0xff, id2 0xff
Probing for W29C040P, 512 KB
probe_jedec: id1 0x60, id2 0x8a
Probing for W29C020C, 256 KB
probe_jedec: id1 0x30, id2 0xc
Probing for W29EE011, 128 KB
probe_w29ee011: id1 0xff, id2 0xff
Probing for W49F002U, 256 KB
probe_jedec: id1 0x30, id2 0xc
Probing for W49V002A, 256 KB
probe_jedec: id1 0x30, id2 0xc
Probing for W49V002FA, 256 KB
probe_jedec: id1 0x30, id2 0xc
Probing for W39V040FA, 512 KB
probe_jedec: id1 0x60, id2 0x8a
Probing for W39V040A, 512 KB
probe_jedec: id1 0x60, id2 0x8a
Probing for W39V040B, 512 KB
probe_jedec: id1 0x60, id2 0x8a
Probing for W39V080A, 1024 KB
probe_jedec: id1 0xff, id2 0xff
Probing for W25x10, 128 KB
generic_spi_command called, but no SPI chipset detected
Probing for W25x20, 256 KB
generic_spi_command called, but no SPI chipset detected
Probing for W25x40, 512 KB
generic_spi_command called, but no SPI chipset detected
Probing for W25x80, 1024 KB
generic_spi_command called, but no SPI chipset detected
Probing for M29F002B, 256 KB
probe_jedec: id1 0x30, id2 0xc
Probing for M50FW040, 512 KB
probe_jedec: id1 0x60, id2 0x8a
Probing for M29W040B, 512 KB
probe_jedec: id1 0x60, id2 0x8a
Probing for M29F002T/NT, 256 KB
probe_jedec: id1 0x30, id2 0xc
Probing for M29F400BT, 512 KB
probe_m29f400bt: id1 0x60, id2 0xb
Probing for M50FLW040A, 512 KB
probe_jedec: id1 0x60, id2 0x8a
Probing for M50FLW040B, 512 KB
probe_jedec: id1 0x60, id2 0x8a
Probing for M50FLW080A, 1024 KB
probe_jedec: id1 0xff, id2 0xff
Probing for M50FLW080B, 1024 KB
probe_jedec: id1 0xff, id2 0xff
Probing for M50FW080, 1024 KB
probe_jedec: id1 0xff, id2 0xff
Probing for M50FW016, 2048 KB
probe_jedec: id1 0xff, id2 0xff
Probing for M50LPW116, 2048 KB
probe_jedec: id1 0xff, id2 0xff
Probing for M29W010B, 128 KB
probe_jedec: id1 0xff, id2 0xff
Probing for M29F040B, 512 KB
probe_29f040b: id1 0x60, id2 0x8a
Probing for M25P05-A, 64 KB
generic_spi_command called, but no SPI chipset detected
Probing for M25P10-A, 128 KB
generic_spi_command called, but no SPI chipset detected
Probing for M25P20, 256 KB
generic_spi_command called, but no SPI chipset detected
Probing for M25P40, 512 KB
generic_spi_command called, but no SPI chipset detected
Probing for M25P80, 1024 KB
generic_spi_command called, but no SPI chipset detected
Probing for M25P16, 2048 KB
generic_spi_command called, but no SPI chipset detected
Probing for M25P32, 4096 KB
generic_spi_command called, but no SPI chipset detected
Probing for M25P64, 8192 KB
generic_spi_command called, but no SPI chipset detected
Probing for M25P128, 16384 KB
generic_spi_command called, but no SPI chipset detected
Probing for 82802ab, 512 KB
probe_82802ab: id1 0x60, id2 0x8a
Probing for 82802ac, 1024 KB
probe_82802ab: id1 0xff, id2 0xff
Probing for F49B002UA, 256 KB
probe_jedec: id1 0x30, id2 0xc
Probing for LHF00L04, 1024 KB
probe_lhf00l04: id1 0xff, id2 0xff
Probing for S29C51001T, 128 KB
probe_jedec: id1 0xff, id2 0xff
Probing for S29C51002T, 256 KB
probe_jedec: id1 0x30, id2 0xc
Probing for S29C51004T, 512 KB
probe_jedec: id1 0x60, id2 0x8a
Probing for S29C31004T, 512 KB
probe_jedec: id1 0x60, id2 0x8a
Probing for EON unknown SPI chip, 0 KB
WARNING: size: 0 -> 4096 (page size)
generic_spi_command called, but no SPI chipset detected
Probing for MX unknown SPI chip, 0 KB
WARNING: size: 0 -> 4096 (page size)
generic_spi_command called, but no SPI chipset detected
Probing for PMC unknown SPI chip, 0 KB
WARNING: size: 0 -> 4096 (page size)
generic_spi_command called, but no SPI chipset detected
Probing for SST unknown SPI chip, 0 KB
WARNING: size: 0 -> 4096 (page size)
generic_spi_command called, but no SPI chipset detected
Probing for ST unknown SPI chip, 0 KB
WARNING: size: 0 -> 4096 (page size)
generic_spi_command called, but no SPI chipset detected
No EEPROM/flash device found.

Thanks,
Ward.

-- 
Ward Vandewege <ward at fsf.org>
Free Software Foundation - Senior System Administrator