[coreboot] [PATCH] flashrom support for W39V080FA and Kontron 986LCD-M
Peter Stuge
peter at stuge.se
Tue Mar 18 01:51:00 CET 2008
Whoa, hey now. Too fast I think. :)
I'm fine with the Winbond change.
On Mon, Mar 17, 2008 at 11:01:18PM +0100, Stefan Reinauer wrote:
> +static int board_kontron_986lcd_m(const char *name)
> +{
> + struct pci_dev *dev;
> + uint16_t gpiobar;
> + uint32_t val;
> +
> +#define ICH7_GPIO_LVL2 0x38
> +
> + dev = pci_dev_find(0x8086, 0x27b8); /* Intel ICH7 LPC */
> + if (!dev) {
> + // This will never happen on this board
This comment doesn't make much sense.
> + fprintf(stderr, "\nERROR: ICH7 LPC bridge not found.\n");
> + return -1;
> + }
..
> + {0x8086, 0x27b8, 0x0000, 0x0000, 0x0000, 0x0000, 0x0000, 0x0000,
> + "kontron", "986lcd-m", "Kontron 986LCD-M", board_kontron_986lcd_m},
So how is this board differentiated from other systems with ICH7?
Especially tricky since this had particular GPIO used, that may have
a very different meaning elsewhere.
//Peter
More information about the coreboot
mailing list