[coreboot] coreinfo: Use the ESC key to exit the payload

Jordan Crouse jordan.crouse at amd.com
Wed May 14 23:55:35 CEST 2008


On 14/05/08 23:29 +0200, Uwe Hermann wrote:
> On Tue, May 13, 2008 at 05:38:48PM -0600, jordan.crouse at amd.com wrote:
> > Enable the ESC key to close coreinfo - useful if you are using a chooser
> > and want to return to it.
> > 
> > Signed-off-by: Jordan Crouse <jordan.crouse at amd.com>
> > Index: coreinfo/coreinfo.c
> > ===================================================================
> > --- coreinfo.orig/coreinfo.c	2008-05-13 14:52:50.000000000 -0600
> > +++ coreinfo/coreinfo.c	2008-05-13 14:52:54.000000000 -0600
> > @@ -256,6 +256,8 @@
> >  			}
> >  		}
> >  
> > +		if (key == 0x1B)
> 
> How about something like KEY_ESC? Doesn't seem to exist yet, but would
> be nice.

I agree - I'm not sure why its not in curses.h - but its not, not even 
on my system.

What is our policy for changes like this to curses.h?  How closely do we
want to stick with the canonical version that everybody else uses?

Jordan

> 
> Uwe.
> -- 
> http://www.hermann-uwe.de  | http://www.holsham-traders.de
> http://www.crazy-hacks.org | http://www.unmaintained-free-software.org
> 

-- 
Jordan Crouse
Systems Software Development Engineer 
Advanced Micro Devices, Inc.





More information about the coreboot mailing list