[coreboot] [patch] Cleanups in Makefile for flashrom and superiotool

Peter Lemenkov lemenkov at gmail.com
Sun May 18 11:40:15 CEST 2008


Hello All!
In order to simplify the mainteinance of packages for these two
utilities in Fedora/RHEL we need to be able to redefine several
makefile variables such as CFLAGS and PREFIX. There are two ways to do
so:

* first (ugly and a bit annoying) is to patch Makefile each time it
changes by mainstream developers.
* second - we may patch  Makefile one time to allow conditional
assignments for these variables and submit it to upstream (as I'm
doing right now).

Conditional assignment means that instead of defininv variables in the
folowing way:

PREFIX  = /usr/local

we must define it as following:

PREFIX  ?= /usr/local

That means "if prefix was not defined somethere earlier we assign it
to /usr/local".

Another one issue is simplification of "install" section in Makefile.
Installation preserves timestamps, creates necessary directories and
ensures that man-page will not have the executable permission.

Signed-off-by: Peter Lemenkov <lemenkov at gmail.com>
---

Two simple patches attached. They also available at
http://peter.fedorapeople.org/LinuxBIOS/
-- 
With best regards!
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: flashrom--Makefile_cleanup.diff.txt
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20080518/180354d4/attachment.txt>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: superiotool-Makefile_cleanup.diff.txt
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20080518/180354d4/attachment-0001.txt>


More information about the coreboot mailing list