[coreboot] [patch] Cleanups in Makefile for flashrom and superiotool
lemenkov at gmail.com
Sun May 18 15:52:58 CEST 2008
2008/5/18 Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net>:
> OK, you may do that, but what happens if someone defines CFLAGS='-O2'
> and leaves it at that? With the patch you proposed, -DDISABLE_DOC would
> be missing then.
Understood. I'll review this patch.
> If you can solve the conditional define problem as outlined above, I
> think the patch can be Acked. Makefile stuff is very brittle and we had
> several accidents in the past, so getting 2 Acks is a minimum.
With best regards!
More information about the coreboot