[coreboot] r3728 - trunk/coreboot-v2/src/superio/ite/it8712f

[svn at coreboot.org]

Author: mjones
Date: 2008-11-03 23:58:56 +0100 (Mon, 03 Nov 2008)
New Revision: 3728

Modified:
   trunk/coreboot-v2/src/superio/ite/it8712f/superio.c
Log:
Add the missing I/O resources for IT8712F GPIOs. (E.g. some LiPPERT
boards need them to switch the com ports from RS232 to RS485.) The PnP
resources should prevent other devices from being mapped at the same
spot, even if no OS driver actively uses them.

The IT8712F manual makes it look like PNP_IO1 had a size/granularity of
1 byte, but that must be a mistake. The Simple-I/O resource has a size
of 5 bytes (1 for each GPIO set 1-5) and trying different addresses
reveals a granularity of 8.

Signed-off-by: Jens Rottmann <JRottmann at LiPPERTEmbedded.de>
Acked-by: Marc Jones <marc.jones at amd.com>



Modified: trunk/coreboot-v2/src/superio/ite/it8712f/superio.c
===================================================================
--- trunk/coreboot-v2/src/superio/ite/it8712f/superio.c	2008-11-03 22:46:27 UTC (rev 3727)
+++ trunk/coreboot-v2/src/superio/ite/it8712f/superio.c	2008-11-03 22:58:56 UTC (rev 3728)
@@ -129,7 +129,7 @@
 	{&ops, IT8712F_EC, PNP_IO0 | PNP_IO1 | PNP_IRQ0, {0xff8, 0}, {0xff8, 4},},
 	{&ops, IT8712F_KBCK, PNP_IO0 | PNP_IO1 | PNP_IRQ0, {0xfff, 0}, {0xfff, 4},},
 	{&ops, IT8712F_KBCM, PNP_IRQ0,},
-	{&ops, IT8712F_GPIO,},
+	{&ops, IT8712F_GPIO, PNP_IO0 | PNP_IO1 | PNP_IO2 | PNP_IRQ0, {0xfff, 0}, {0xff8, 0}, {0xff8, 0},},
 	{&ops, IT8712F_MIDI, PNP_IO0 | PNP_IRQ0, {0xff8, 0},},
 	{&ops, IT8712F_GAME, PNP_IO0, {0xfff, 0},},
 	{&ops, IT8712F_IR, PNP_IO0 | PNP_IRQ0, {0xff8, 0},},