[coreboot] [PATCH] v3: Kill unnecessary rebuilds

Carl-Daniel Hailfinger c-d.hailfinger.devel.2006 at gmx.net
Thu Nov 6 14:59:47 CET 2008


On 06.11.2008 14:46, Stefan Reinauer wrote:
> Carl-Daniel Hailfinger wrote:
>   
>> Every time we run make in a v3 tree, lar, lzma, nrv2b and the option
>> table get rebuilt unconditionally due to slightly incorrect dependencies.
>> That's wasteful and may hide other dependency bugs.
>> Fix the lar, lzma, nrv2b and option table dependencies.
>>
>> This trims down recompilation time a lot. The only remaining stuff being
>> rebuilt is:
>> ~/corebootv3-better_dependencies> make
>>   CP      build/config.h
>>   GEN     build/build.h
>>   LAR     build/coreboot.rom
>>   PAYLOAD none (as specified by user)
>>   CP      build/bios.bin
>>   DONE
>>
>> Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net>
>>
>>   
>>     
> Acked-by: Stefan Reinauer <stepan at coresystems.de>
>   

Thanks, committed in r984.

>> -nrv2bdir:
>> +$(obj)/util/nrv2b/:
>> -optionsdir:
>> +$(obj)/util/options/:
>>  
>> -LARDIR := lardir
>> +LARDIR := $(obj)/util/lar
>>     
> Is it on purpose that all the other directories have a / at the end but
> $(obj)/util/lar has none?
>   

No, it was a simple typo. Thanks for spotting it.

Regards,
Carl-Daniel

-- 
http://www.hailfinger.org/





More information about the coreboot mailing list