[coreboot] [PATCH] v3: Kill unnecessary rebuilds

[Stefan Reinauer]

Carl-Daniel Hailfinger wrote:
> On 06.11.2008 14:59, Carl-Daniel Hailfinger wrote:
>   
>> On 06.11.2008 14:46, Stefan Reinauer wrote:
>>   
>>     
>>> Carl-Daniel Hailfinger wrote:
>>>   
>>>     
>>>       
>>>> Every time we run make in a v3 tree, lar, lzma, nrv2b and the option
>>>> table get rebuilt unconditionally due to slightly incorrect dependencies.
>>>> That's wasteful and may hide other dependency bugs.
>>>> Fix the lar, lzma, nrv2b and option table dependencies.
>>>>
>>>> This trims down recompilation time a lot. The only remaining stuff being
>>>> rebuilt is:
>>>> ~/corebootv3-better_dependencies> make
>>>>   CP      build/config.h
>>>>   GEN     build/build.h
>>>>   LAR     build/coreboot.rom
>>>>   PAYLOAD none (as specified by user)
>>>>   CP      build/bios.bin
>>>>   DONE
>>>>
>>>> Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net>
>>>>
>>>>   
>>>>     
>>>>       
>>>>         
>>> Acked-by: Stefan Reinauer <stepan at coresystems.de>
>>>   
>>>     
>>>       
>> Thanks, committed in r984.
>>   
>>     
>
> I wanted to clean this up further, but I'm hitting a big dependency bug.
> Try this patch and watch make explode:
>
> Index: util/lar/Makefile
> ===================================================================
> --- util/lar/Makefile	(Revision 984)
> +++ util/lar/Makefile	(Arbeitskopie)
> @@ -22,10 +22,8 @@
>  LARDIR := $(obj)/util/lar/
>  
>  COMPRESSOR := $(LZMA_OBJ) $(obj)/util/lzma/lzma-compress.o
> -LARDIR     += $(obj)/util/lzma/
>  
>  COMPRESSOR += $(obj)/util/nrv2b/nrv2b-compress.o
> -LARDIR     += $(obj)/util/nrv2b/
>  
>  LAROBJ_ABS := $(patsubst %,$(obj)/util/lar/%,$(LAROBJ))
>  
>   
> Fixing this would require us to add build/util/lzma/ as a dependency to
> every lzma object in util/lzma/Makefile. And that's the point where I
> ask about better solutions.

I think leaving it as it is sounds like a better solution already ;-)

-- 
coresystems GmbH • Brahmsstr. 16 • D-79104 Freiburg i. Br.
      Tel.: +49 761 7668825 • Fax: +49 761 7664613
Email: info at coresystems.de  • http://www.coresystems.de/
Registergericht: Amtsgericht Freiburg • HRB 7656
Geschäftsführer: Stefan Reinauer • Ust-IdNr.: DE245674866


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 249 bytes
Desc: OpenPGP digital signature
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20081106/4799f6db/attachment.sig>