[coreboot] r988 - coreboot-v3/arch/x86

svn at coreboot.org svn at coreboot.org
Sat Nov 8 23:39:35 CET 2008


Author: hailfinger
Date: 2008-11-08 23:39:35 +0100 (Sat, 08 Nov 2008)
New Revision: 988

Modified:
   coreboot-v3/arch/x86/Makefile
Log:
initram is linked with very special options to ld. It is not immediately
obvious that they are needed, so a comment to that effect will hopefully
prevent accidental "cleanups" in the future when nobody remembers the
history of that makefile rule anymore.

Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net>
Acked-by: Peter Stuge <peter at stuge.se>


Modified: coreboot-v3/arch/x86/Makefile
===================================================================
--- coreboot-v3/arch/x86/Makefile	2008-11-07 16:33:57 UTC (rev 987)
+++ coreboot-v3/arch/x86/Makefile	2008-11-08 22:39:35 UTC (rev 988)
@@ -274,6 +274,8 @@
 	$(Q)$(AS) $(obj)/initram_picwrapper.s -o $(obj)/initram_picwrapper.o
 	$(Q)# initram links against stage0
 	$(Q)printf "  LD      $(subst $(shell pwd)/,,$(@))\n"
+	$(Q)# WARNING: Using -N (and not -n or others) for ld is essential to
+	$(Q)# get all important stuff into one segment!
 	$(Q)$(LD) -Ttext 0 --entry main -N -R $(obj)/stage0-prefixed.o \
 		$(obj)/coreboot.initram_partiallylinked.o \
 		$(obj)/initram_picwrapper.o -o $(obj)/coreboot.initram





More information about the coreboot mailing list