[coreboot] [PATCH] fix Multiboot header in libpayload

Jordan Crouse jordan at cosmicpenguin.net
Wed Nov 12 00:36:51 CET 2008


Robert Millan wrote:
> On Tue, Nov 11, 2008 at 10:04:57PM +0100, Uwe Hermann wrote:
>>> -	echo "$DEFAULT_CC $_CFLAGS $_LDFLAGS $CMDLINE $_LIBDIR/i386/head.o $_LIBDIR/libpayload.a $_LIBGCC"
>>> +	echo "$DEFAULT_CC $_CFLAGS $_LDFLAGS $_LIBDIR/i386/head.o $CMDLINE $_LIBDIR/libpayload.a $_LIBGCC"
>> Please also add a comment here, this is highly non-obvious from just
>> looking at the file's contents otherwise.
> 
> Done.

This works, as long as nobody adds 8k of cruft to the head.S file, which 
I seriously doubt.   This will change the entry point of the ELF, so 
those of you used to debugging payloads may be in for a bit of surprise.

Acked-by: Jordan Crouse <jordan at cosmicpenguin.net>

r3748

Thanks.




More information about the coreboot mailing list