[coreboot] [PATCH] add debug information to v2 builds

[Carl-Daniel Hailfinger]

On 27.11.2008 14:40, Stefan Reinauer wrote:
> This patch from Ralf Grosse Boerger makes debugging more comfortable. 
> With this patch it's possible to 
>
> - determine the according source code line for each asm statement
>   (objdump -dS)
> - determine the source code file for each asm statement 
>   (objdump -ddl)
>
> This isn't exactly trivial because cache_as_ram_auto.c gets compiled to
> assembly and converted by a perl script afterwards.
>
> This patch solves the problem 
> - by extending cache_as_ram_auto.inc with debug information and line numbers
> - by correcting the perl calls (".text" --> "\.text")
> - by creating a disassembly with source code and line numbers. (ctr0.disasm and
>   coreboot.disasm)
>
> There's one minor downside to the patch: A complete abuild run takes up around
> 1.6G instead of about 700MB now. But I'm sure this is quite reasonable for the
> benefits.
>
> Signed-off-by: Stefan Reinauer <stepan at coresystems.de>

It would be great if you could split the regular expression bugfix from
the rest of the patch. That makes reviewing a lot easier and the
individual patches are smaller.

The perl regexp change is
Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net>


Regards,
Carl-Daniel

-- 
http://www.hailfinger.org/