[coreboot] [PATCH] flashrom: Differentiate SPI errors

FENG Yu Ning fengyuning1984 at gmail.com
Thu Nov 27 19:46:22 CET 2008


On Fri, Nov 28, 2008 at 1:45 AM, Carl-Daniel Hailfinger
<c-d.hailfinger.devel.2006 at gmx.net> wrote:

> +/* Error codes */
> +#define SPI_INVALID_OPCODE     2
> +#define SPI_INVALID_ADDRESS    3

I did meet access block problem because of reading addresses below
BBA, when trying to implement sst25lf040a support. I was given
"Transaction error", and it took me a little while to figure out the
reason.

>        /* unknown / not programmed command */
>        if (opcode_index == -1) {
>                printf_debug("Invalid OPCODE 0x%02x\n", cmd);
> -               return 1;
> +               return SPI_INVALID_OPCODE;

Looking forward to more diagnostic output.

yu ning




More information about the coreboot mailing list