[coreboot] Patches for ACPI support on dbm690t (RS600 and SB600)

Bao, Zheng Zheng.Bao at amd.com
Fri Nov 28 07:14:50 CET 2008


Hi,
We forgot to add "signed-off-by & reviewed-by" in our previous shot. We add more clean-up this time. Please ack these ones. Thanks a lot.

Signed-off-by:  Joe Bao <zheng.bao at amd.com>
Reviewed-by:    Maggie Li <maggie.li at amd.com>


Joe

-----Original Message-----
From: coreboot-bounces at coreboot.org [mailto:coreboot-bounces at coreboot.org] On Behalf Of Bao, Zheng
Sent: Thursday, November 27, 2008 10:16 AM
To: coreboot at coreboot.org
Cc: Li, Maggie; ron minnich; Xie, Michael; Huang, FrankR; Feng, Libo; Wang, Qingpei
Subject: Re: [coreboot] Patches for ACPI support on dbm690t (RS600 and SB600)

Hi, Ron,
We have modified the patch as you told us.
Thanks.


Joe

-----Original Message-----
From: ron minnich [mailto:rminnich at gmail.com] 
Sent: Wednesday, November 26, 2008 11:46 PM
To: Bao, Zheng
Cc: coreboot at coreboot.org; Huang, FrankR; Feng, Libo; Li, Maggie; Wang,
Qingpei; Xie, Michael
Subject: Re: [coreboot] Patches for ACPI support on dbm690t (RS600 and
SB600)

On Tue, Nov 25, 2008 at 9:18 PM, Bao, Zheng <Zheng.Bao at amd.com> wrote:
> Hi,
> Attachment are the patches for Chipset AMD RS690, AMD SB600 and
mainboard DBM690T. The following ACPI features are supported.
> 1. S1, S5 sleep and wake up (by power button or PS/2 keyboard/mouse).
> 2. AMD powernow-k8 driver.
> 3. Thermal configuration based on ADT7461.
> 4. IDE timing settings.
> 5. HPET timer.
> 6. Interrupt routing based on ACPI table.


I would request one change. When there is a HALT type error, such as
this:
printk_info("rs690_enable: CAN NOT FIND SB bridge, HALT!\n");
it would be best to do this instead:
die("rs690_enable: CAN NOT FIND SB bridge, HALT!\n");

So, for example:
		printk_info("rs690_enable: CAN NOT FIND SB bridge,
HALT!\n");
 		for (;;) ;

becomes instead:
		die("rs690_enable: CAN NOT FIND SB bridge, HALT!\n");
 		/*NOTREACHED*/

The rest of this patch looks fine.

If you can change the "HALT" printk_info to die, then:
Acked-by: Ronald G. Minnich <rminnich at gmail.com>

ron

-------------- next part --------------
A non-text attachment was scrubbed...
Name: dbm690t_acpi.patch
Type: application/octet-stream
Size: 137471 bytes
Desc: dbm690t_acpi.patch
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20081128/54e4b1ab/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: rs690_acpi.patch
Type: application/octet-stream
Size: 12817 bytes
Desc: rs690_acpi.patch
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20081128/54e4b1ab/attachment-0001.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: sb600_acpi.patch
Type: application/octet-stream
Size: 15675 bytes
Desc: sb600_acpi.patch
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20081128/54e4b1ab/attachment-0002.obj>


More information about the coreboot mailing list