[coreboot] [v2][patch] update k8 fid/vid setup
Marc.Jones at amd.com
Fri Oct 10 21:55:55 CEST 2008
Uwe Hermann wrote:
> On Wed, Oct 01, 2008 at 02:57:03PM -0600, Marc Jones wrote:
>> Resubmitting this patch. I think I worked out all the corner cases and
>> made it a little easier to understand.
> This will probably break the build on some boards, e.g.:
> Processing mainboard/asus/a8v-e_se (i386: ok)
> Creating config file... ok
> Creating builddir...ok
> Compiling image on 1 cpu .. FAILED after 4s! Log excerpt:
> cache_as_ram_auto.c:(.rom.text+0x3a34): undefined reference to `printk_debug'
> collect2: ld returned 1 exit status
> make: *** [coreboot] Error 1
> I think the reason is this:
>> + printk_debug("Current fid_cur: %x\n", fid_cur);
>> + printk_debug("Requested fid_new: %x\n", fid_new);
> All other printk_*'s in this file are "protected" similar to this:
> #if K8_SET_FIDVID_DEBUG == 1
> #if CONFIG_USE_PRINTK_IN_CAR
> printk_debug("%s%x\r\n", str, val);
> print_debug(str); print_debug_hex32(val); print_debug("\r\n");
I fixed several platforms that didn't have prink_* support for a
different fix. I would rather fix the platforms since K8 always has CAR.
The print_* PRINTK_IN_CAR is really ugly and would like it to go away....
I will run abuild and see what platforms need some printk love.
Senior Firmware Engineer
(970) 226-9684 Office
mailto:Marc.Jones at amd.com
More information about the coreboot