[coreboot] [PATCH] v2: Drop unused reset.c files

Uwe Hermann uwe at hermann-uwe.de
Mon Oct 13 16:02:35 CEST 2008


On Mon, Oct 13, 2008 at 03:51:02PM +0200, Stefan Reinauer wrote:
> > Index: src/mainboard/digitallogic/msm586seg/Config.lb
> > ===================================================================
> > --- src/mainboard/digitallogic/msm586seg/Config.lb	(Revision 3653)
> > +++ src/mainboard/digitallogic/msm586seg/Config.lb	(Arbeitskopie)
> > @@ -46,7 +46,7 @@
> >  
> >  driver mainboard.o
> >  if HAVE_PIRQ_TABLE object irq_tables.o end
> > -object reset.o
> > +# object reset.o
> >  
> >  ##
> >  ## Romcc output
> > Index: src/mainboard/digitallogic/msm586seg/Options.lb
> > ===================================================================
> > --- src/mainboard/digitallogic/msm586seg/Options.lb	(Revision 3653)
> > +++ src/mainboard/digitallogic/msm586seg/Options.lb	(Arbeitskopie)
> > @@ -72,7 +72,7 @@
> >  ##
> >  ## Build code to reset the motherboard from coreboot
> >  ##
> > -default HAVE_HARD_RESET=1
> > +default HAVE_HARD_RESET=0
> >  
> >  ##
> >  ## Build code to export a programmable irq routing table
> Ahem.... Are you sure the stuff you dropped is actually unused?! It
> looks like you made it unused before dropping it.

Only in one or two cases, yes. For this board the contents of reset.c
where (more or less):

  void hard_reset(void)
  {
  }

which is useless, but causes a compile error if I don't do the
"# object reset.o" and "default HAVE_HARD_RESET=0" above.
So I think that the file was not really needed here, but please correct
me if I'm wrong or if I removed some other required stuff.


Uwe.
-- 
http://www.hermann-uwe.de  | http://www.holsham-traders.de
http://www.crazy-hacks.org | http://www.unmaintained-free-software.org




More information about the coreboot mailing list