[coreboot] : v2: Move AMD RS690/SB600 PCI IDs to pci_ids.h
jordan.crouse at amd.com
Tue Oct 14 16:35:14 CEST 2008
On 13/10/08 16:07 -0600, Marc Jones wrote:
> Uwe Hermann wrote:
> > On Mon, Oct 13, 2008 at 02:50:05PM -0600, Marc Jones wrote:
> >>> Move AMD RS690 and SB600 PCI IDs to pci_ids.h where they should be.
> >>> Build-tested with the AMD dbm690t board.
> >>> Signed-off-by: Uwe Hermann <uwe at hermann-uwe.de>
> >> Acked-by: Marc Jones <marc.jones at amd.com>
> > Thanks, r3655.
> > Btw, should PCI_DEVICE_ID_ATI* be renamed to PCI_DEVICE_ID_AMD*
> > for the RS690 and SB600? Or should we keep the old names?
> Yes you are correct. We should change that.
I disagree - the vendor ID is still 0x1002 which is technically assigned
to ATI - the kernel has always had the policy of matching the vendor ID
to the assignee of the number, not the current owner of the IP. As an
example, note that the CS5535 IDs in the kernel are still tagged with
I think we should keep the old names so that they match the vendor ID.
Systems Software Development Engineer
Advanced Micro Devices, Inc.
More information about the coreboot