[coreboot] [RFC] v3: Stack switching abstraction for C7 and later Intel processors

Marc Jones Marc.Jones at amd.com
Tue Oct 14 18:31:12 CEST 2008


ron minnich wrote:
> Here is a version I put together yesterday as a straw main.
> 
> summary:
> 
> stage1_main is now split into stage0_main and main(). stage0_main runs
> up to and including initram. It then calls disable_car.
> 
> disable_car does what it does now:
> copy CAR stack to ram stack, disable car,
> BUT:
> instead of a ret, it does a ljmp to main.


Why not ret and do a call (or ljmp) from stage0_main to main(). It would 
make the code easier to follow and it would be easy to add code if 
anything were required between disable car and the jmp.

Marc


-- 
Marc Jones
Senior Firmware Engineer
(970) 226-9684 Office
mailto:Marc.Jones at amd.com
http://www.amd.com/embeddedprocessors





More information about the coreboot mailing list