[coreboot] v3 comments - was Serengeti vga hang

Marc Jones Marc.Jones at amd.com
Wed Oct 15 21:41:29 CEST 2008


ron minnich wrote:
> On Wed, Oct 15, 2008 at 11:02 AM, Marc Jones <Marc.Jones at amd.com> wrote:
>> ron minnich wrote:
> 
>> Sorry but I don't see any phase4_enable_disable in the output. It is not
>> being called in device.c dev_phase4(). I think that is a problem.
>>
>>
> 
> see pci_probe_dev.
> 
> And, hey, if I could get you all to use kscope, you would just ask
> kscope to show you where it's called :-)
> 
> I'm not saying it's right but ... it's there.

Should it really be a phase3 function? Should it be run after any 
phase3_enable_scan?

Marc




-- 
Marc Jones
Senior Firmware Engineer
(970) 226-9684 Office
mailto:Marc.Jones at amd.com
http://www.amd.com/embeddedprocessors





More information about the coreboot mailing list