[coreboot] SimNOW VGA int 1a

[Carl-Daniel Hailfinger]

On 16.10.2008 01:13, Peter Stuge wrote:
> ron minnich wrote:
>   
>> Myles, try setting -mregparm=0 and see if life is better.
>>     
>
> Good find.
>   

__attribute__((stdcall)) will do this for you.
Changing compilation mode makes code to -mregparm=0 makes the code
bigger and slower and it will also possibly consume more stack which we
don't have in MP setups.


>> I vote we get rid of this type of Cleverness. It's just not
>> performance critical in a bios. We're not an OS and we should keep
>> it simple. I don't think we'll live or die on 3 on-stack variables.
>>     
>
> If it isn't more relevant because of CAR then away it goes.
>   

See above.

Regards,
Carl-Daniel

-- 
http://www.hailfinger.org/