[coreboot] patch: add routing debug print to v3

ron minnich rminnich at gmail.com
Mon Oct 20 22:38:22 CEST 2008


On Mon, Oct 20, 2008 at 12:59 PM, Carl-Daniel Hailfinger
<c-d.hailfinger.devel.2006 at gmx.net> wrote:
> On 20.10.2008 19:28, ron minnich wrote:
>> attached.
>>
>> corrections and improvements welcome. Builds fine on serengeti. Not
>> testing until we work around the vga issue.
>>
>>
>> These changes add support for utility functions to dump routing. They
>> also add a mainboard.c for serengeti that will call them.
>>
>
> Since it is in the mainboard directory, the name "mainboard.c" does not
> convey any additional information. However, the name stage2.c would be
> rather helpful. Your choice, though.

great idea. I will change it.

>> Index: northbridge/amd/k8/Makefile
>> Add util.c to stage2 files.
>>
>> Index: northbridge/amd/k8/util.c
>> Utility to print routing registers.


I am going to change these util functions to work from any stage. This
means they will take a devno (0x18, 0x19, etc) and use the
pci_conf1 pci functions. At that point they can be called any time. I
will submit a new patch tonight.

ron




More information about the coreboot mailing list