[coreboot] HT devices in v3

[Marc Jones]

Myles Watson wrote:
> I'm getting stuck in Hypertransport enumeration.  Is there supposed to be a
> pci_domain that is the child of a HT link?  If so, what device ID would it
> have.
>
> I'm thinking specifically about the 8132 and 8111 on the Serengeti board.
> The dts currently looks like this (simplified):
>
> 	domain at 0 {
> 		/config/("northbridge/amd/k8/domain");
> 		pci at 1,0{
> 		};
> 		pci0 at 18,0 {
> 			/config/("northbridge/amd/k8/pci");
> 			pci at 0,0 {
> 				/config/("southbridge/amd/amd8111/pci.dts");
> 				pci at 1,0{
> 	
> /config/("southbridge/amd/amd8111/nic.dts");
> 				};
> 				pci at 0,0{
> 	
> /config/("southbridge/amd/amd8111/usb.dts");
> 				};
> 			};
> 			pci at 7,0 {
> 				/config/("southbridge/amd/amd8111/lpc.dts");
> 			};
> 		};
>
> I think it should look like this:
>
> 	domain at 0 {
> 		/config/("northbridge/amd/k8/domain");
> 		pci0 at 18,0 {
> 			/config/("northbridge/amd/k8/pci");
> 			pci at 0,0 { //Really at 00:6.0
> 				/config/("southbridge/amd/amd8111/pci.dts");
> 				pci at 1,0{
> 	
> /config/("southbridge/amd/amd8111/nic.dts");
> 				};
> 				pci at 0,0{
> 	
> /config/("southbridge/amd/amd8111/usb.dts");
> 				};
> 			};
> 			pci at 1,0 { //Really at 00:7.0
> 				/config/("southbridge/amd/amd8111/lpc.dts");
> 			};
> 			pci at 2,0{  //Really at 00:a.0 and 00:b.0
> 	
> /config/("southbridge/amd/amd8132/pcix.dts");
> 			};
> 		};
>
> My reasoning is that the 8132 and the 81111 should be at the same level.
> This doesn't work for me in hypertransport enumeration for various reasons.
> Before I do a big rewrite, I'd like a little sanity check.
>
> By the way, "dynamic" in the dtsname is bad when you had the device in the
> dts.  It means it didn't find your device where you said it was.
>
> Thanks,
> Myles
>
>   
Myles,
You are right that they should be on the same level. I am not an expert 
enough on dts but I think you are on the right path. The devices need to 
be put in the correct place so we don't get dynamic. I expect that Ron 
will have some comment.

Thanks,
Marc


-- 
Marc Jones
Senior Firmware Engineer
(970) 226-9684 Office
mailto:Marc.Jones at amd.com
http://www.amd.com/embeddedprocessors