[coreboot] More v3 quesions

[Corey Osgood]

On Thu, Oct 23, 2008 at 9:04 PM, ron minnich <rminnich at gmail.com> wrote:

> On Thu, Oct 23, 2008 at 5:30 PM, Corey Osgood <corey.osgood at gmail.com>
> wrote:
> > I've got a few more questions that I could probably figure out answers to
> by
> > testing, but hopefully it's easier just to ask:
> >
> > * If a device is defined in the dts, but disabled during
> > phase4_enable_disable which renders the device hidden, what will/should
> v3
> > do?
>
> the device should end up not even being found. marc felt that
> phase4_enable_disable was ill-defined and we are working on making
> this clearer.


Alright, but what happens after that? coreboot dies with loud warning
messages, or moves on to the next device?

>
> > * If another device appears where the disabled device should have been
> (in
> > this case, the ide controller is now where sata used to be), what should
> > happen? Will the ide controller's config (that was intended for another
> > location) be used? In this case, it's D10F0 and F1.
> >
>
> It should not because the devid and vendor id should not match.


Let me try to clarify that: if the sata controller at d10f0 disappears, and
the ide controller moves from d10f1 to d10f0 (and maintains its original
vendor/dev ids), will the dts configuration that was intended for the ide
controller at d10f1 be used? If not, could the ide controller and sata
controller both be configured for d10f0, with the sata controller set to
disabled?

Thanks!
Corey


> > * phase4_enable_disable passes the actual device it's enabling/disabling,
> > right?
>
> yes.
>
> >
> > * What's the format of devfn (as in dev->path.pci.devfn)? dev << 4 |
> > function?
> >
>
> dev <<3 | fn
>
> ron
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20081023/9a5cc148/attachment.html>