[coreboot] v3 \r\n

Jordan Crouse jordan.crouse at amd.com
Tue Oct 28 18:23:07 CET 2008


On 28/10/08 11:08 -0600, Myles Watson wrote:
> Is there any time when we really want \r\n?
> 
> I found some \r in halt and catch fire that seemed on purpose, but all of
> the \r\n locations seem to be mistakes (they are mixed with \n in the same
> file.)
> 
> It seems like a trivial patch to remove them all so that we're consistent,
> but If there's a good reason for them ...

I think they should all be \n.  If we need the \r for the debug output,
then the extra character should be added in the output function.

Jordan

-- 
Jordan Crouse
Systems Software Development Engineer 
Advanced Micro Devices, Inc.





More information about the coreboot mailing list