[coreboot] v3 __func0 cleanup

ron minnich rminnich at gmail.com
Wed Oct 29 01:29:46 CET 2008


On Tue, Oct 28, 2008 at 1:02 PM, Myles Watson <mylesgw at gmail.com> wrote:
> This patch documents the unreadable function in northbridge/amd/k8/pci.c and
> cleans up the NULL pointer protection.
>
> Signed-off-by: Myles Watson <mylesgw at gmail.com>
>
> It also begs the question why cpu_bus_scan and cpu_bus_init aren't needed in
> v3.  They aren't called.  Is that an oversight, or should they be removed.
>

This is a big improvement.

I am not sure those functions are needed but let's not remove them
just yet. Peter, stefan and I are doing more looking at device code.

Found more ugliness, trying to do more cleanup.

ron




More information about the coreboot mailing list