[coreboot] [PATCH 5/6] Changes required to the device allocator

Myles Watson mylesgw at gmail.com
Wed Oct 29 04:08:50 CET 2008


> Changes required to the device allocator:
> - leave a hole for mmapped PCIe config space if
CONFIG_PCIE_CONFIGSPACE_HOLE
>   is set.
> - Mask moving bits to 32bit when resources are not supposed above 4G.
Linux
>   does not like this, even though the resource is disabled.
> 
> Signed-off-by: Stefan Reinauer <stepan at coresystems.de>

Looks good.  would it be better to set the resource to 0 instead of to
moving bits?  Then there would not be a need for the special case.  It also
makes it easier to read the config space.

Acked-by: Myles Watson <mylesgw at gmail.com>

Thanks,
Myles





More information about the coreboot mailing list