[coreboot] r3705 - in trunk/coreboot-v2/src: include/device northbridge/intel/i945 southbridge/intel/i82801gx
Peter Stuge
peter at stuge.se
Wed Oct 29 17:02:17 CET 2008
svn at coreboot.org wrote:
> static const struct pci_driver mc_driver __pci_driver = {
> .ops = &mc_ops,
> .vendor = PCI_VENDOR_ID_INTEL,
> - .device = 0x27a0,
> + .device = PCI_DEVICE_ID_INTEL_945_HOST_BRIDGE,
Sorry, but I don't really agree with these changes.
> static const struct pci_driver i82801gx_ide __pci_driver = {
> .ops = &ide_ops,
> .vendor = PCI_VENDOR_ID_INTEL,
> - .device = 0x27df,
> + .device = PCI_DEVICE_ID_INTEL_82801GB_IDE,
> };
My reasoning is that #defines should add information to the code and
not be an end in itself.
> -static const struct pci_driver i82801ex_usb_ehci __pci_driver = {
> .ops = &usb_ehci_ops,
> .vendor = PCI_VENDOR_ID_INTEL,
> - .device = 0x27cc,
> + .device = PCI_DEVICE_ID_INTEL_82801GB_EHCI,
> };
In all these cases I quote above it is already perfectly clear from
the struct name which device is refered to, in which case I think it
would be more informative to have the literal device PCI id.
//Peter
More information about the coreboot
mailing list