[coreboot] r964 - coreboot-v3/util/x86emu

[Marc Jones]

Myles Watson wrote:
> 
> 
> On Wed, Oct 29, 2008 at 3:11 PM, Jordan Crouse <jordan.crouse at amd.com 
> <mailto:jordan.crouse at amd.com>> wrote:
> 
>     On 29/10/08 15:00 -0600, Myles Watson wrote:
>      > > Modified:
>      > >   coreboot-v3/util/x86emu/vm86.c
>      > > Log:
>      > > This patch makes the vm86 call succeed. It
>      > > 1. moves the run_bios function down so it can call
>     setup_realmode_idt
>      > > 2. adds the __attribute__((regnum(0))) to biosint because it is
>     called from
>      > > assembly
>      > >
>      > >
>      > Anybody who wants to test this in SimNOW either needs to unshare
>     pci and
>      > printk, or remove calls into the ROM while the VGA ROM is running.
>      > Otherwise when the ROM gets sized, your code disappears.
>      >
>      > Signed-off-by: Myles Watson <mylesgw at gmail.com
>     <mailto:mylesgw at gmail.com>>
> 
>     We already have Simnow ifdefs in the code - would those help to make
>     the code work out of the box?
> 
> 
> I think we decided that the "right" thing to do was to unshare the code, 
> mirror the ROM, or something else that makes the solution more general.  
> Since you can't trust ROMs in general, it's not specific to SimNOW.  I 
> just wanted others to be able to test it.
> 

Yes, we just need to fix it. This will break real hardware too.
Marc

-- 
Marc Jones
Senior Firmware Engineer
(970) 226-9684 Office
mailto:Marc.Jones at amd.com
http://www.amd.com/embeddedprocessors