[coreboot] Incorrect casting in romcc.

Mats Erik Andersson mats.andersson at gisladisker.se
Fri Sep 12 17:04:29 CEST 2008


Stefan Reinauer skrev alldeles nyss
> Mats Erik Andersson wrote:
> > 	data += ( fn(0x10) >> 1 ) && 0x007f;
> >
> > where fn(0x10) == 0x1010. However, the actual outcome of the previous
> > calculation is the value 0x01, instead of the expected 0x08. 
> 1 is very much the expected result because the above is a boolean
> expression, not a bitwise AND.
> 
> Looks like a bug in the 440bx ram init code.
> 
> Stefan
> 

Very true indeed. I made a mistake with the logical connective.
Let there henceforth be silence on this embarrassing event,
since the casting indeed is proven correct when my misprint
has been corrected. Very sorry for the noise!

Kind regards,

Mats E Andersson




More information about the coreboot mailing list