[coreboot] buildrom: Automaticaly pad ROMs
jordan.crouse at amd.com
Wed Sep 24 00:19:44 CEST 2008
On 23/09/08 16:25 -0400, Ward Vandewege wrote:
> On Mon, Sep 22, 2008 at 04:04:25PM -0600, Jordan Crouse wrote:
> > The potential pitfalls for this patch are many, but I think the
> > reward outweights the risk.
> > The script will need the usual 0755 treatment.
> > Jordan
> > --
> > Jordan Crouse
> > Systems Software Development Engineer
> > Advanced Micro Devices, Inc.
> > !DSPAM:48d8163d42417432833338!
> > buildrom: Add script to automatically pad ROMs
> > Many ROMs may need to be padded before use. This script tries to do
> > this somewhat automatically. If the platform needs the payload to be
> > padded to a power of 2, then it should set PAYLOAD_DOPAD to '-p'.
> > Otherwise, the script behaves as it normally does.
> > Signed-off-by: Jordan Crouse <jordan.crouse at amd.com>
> Acked-by: Ward Vandewege <ward at gnu.org>
> It works unless the vga bios file is zero bytes long :)
Fixed - turns out that expr has a trick up its sleeve:
Exit status is 0 if EXPRESSION is neither null nor 0, 1 if EXPRESSION
is null or 0, 2 if EXPRESSION is syntactically invalid, and 3 if
an error occurred
bin/construct-rom.sh runs with -e, so thats your failure. I fixed it
by oring the result of the expr with || true.
buildrom should be completely dbm690t happy now, except for the vbios
URL which is ongoing.
Systems Software Development Engineer
Advanced Micro Devices, Inc.
More information about the coreboot